Conversation
Add generic operator S3 to SQL
|
General questions and reminders:
Thank you for adding this operator :) |
Thanks for your comments. In my case, I execute this operator on ECS cluster by docker image =)) so I will test this operator and add unit test later. |
docs/apache-airflow-providers-amazon/operators/transfer/s3_to_sql.rst
Outdated
Show resolved
Hide resolved
|
@vincbeck @josh-fell @Mik-lạ. Please review my operator. Thanks |
vincbeck
left a comment
There was a problem hiding this comment.
Looking good to me! Just one minor comment from me
|
@potiuk please review my operator. thanks |
|
any update? @josh-fell @mik-laj |
| from airflow.utils.session import create_session | ||
|
|
||
|
|
||
| class TestS3ToSqlTransfer(unittest.TestCase): |
There was a problem hiding this comment.
For net-new tests, it's preferred to use pytest rather than unittest.
There was a problem hiding this comment.
@thinhnd2104 A friendly reminder to have this new test use pytest instead of unittest. No rush of course.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
|
@thinhnd2104 This PR has been closed as stale, are you planning to resume work on it? |
Relate #23666