[AIRFLOW-1321] Fix hidden field key to ignore case#2400
Merged
asfgit merged 1 commit intoapache:masterfrom Jul 4, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2400 +/- ##
==========================================
- Coverage 69.26% 69.23% -0.03%
==========================================
Files 146 146
Lines 11231 11231
==========================================
- Hits 7779 7776 -3
- Misses 3452 3455 +3
Continue to review full report at Codecov.
|
Contributor
|
@sekikn +1 for moving sensitive field list from views to utils. Please update your commit message as per the below guidelines, then you are all good:
|
Webserver has a feature to hide sensitive variable fields, which key contain specific words. But its matching is case-sensitive, so "google_api_key" is hidden but "GOOGLE_API_KEY" is not. This behaviour is not intuitive, so this PR fixes it to be case-insensitive.
Contributor
Author
|
Thanks for the review @msumit! Updated the subject within 50 characters. |
Contributor
|
lgtm |
asfgit
pushed a commit
that referenced
this pull request
Jul 4, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
Webserver has a feature to hide sensitive variable fields,
which key contain specific words. But its matching is
case-sensitive, so "google_api_key" is hidden but
"GOOGLE_API_KEY" is not. This behaviour is not intuitive,
so this PR fixes it to be case-insensitive.
Tests
Added tests/www/test_utils.py.

In addition, I confirmed the feature behaved expectedly as the following screenshot:
Commits