[AIRFLOW-1389] BigQueryOperator should support createDisposition
#2470
Conversation
|
@yu-iskw, thanks for your PR! By analyzing the history of the files in this pull request, we identified @criccomini, @mistercrunch and @mtagle to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #2470 +/- ##
==========================================
+ Coverage 69.39% 69.43% +0.04%
==========================================
Files 146 146
Lines 11349 11351 +2
==========================================
+ Hits 7876 7882 +6
+ Misses 3473 3469 -4
Continue to review full report at Codecov.
|
|
@criccomini Can you review it, when you have time? |
| def run_query( | ||
| self, bql, destination_dataset_table = False, | ||
| write_disposition = 'WRITE_EMPTY', | ||
| create_disposition='CREATE_IF_NEEDED', |
There was a problem hiding this comment.
I'm a little worried about this. For non named-parameter calls, this would be a backwards incompatible change. I know it's ugly, but how would you feel about putting it at the end of the param list?
There was a problem hiding this comment.
That is a good point. I was thinking the same thing as well. Alright, I will put the new parameter to the backwards. Thanks for the comment.
| bql, | ||
| destination_dataset_table=False, | ||
| write_disposition='WRITE_EMPTY', | ||
| create_disposition='CREATE_IF_NEEDED', |
|
@criccomini Thanks for the feedback. I have modified the order of parameters. |
|
LGTM! Merged. |
|
@criccomini Thank you for merging it! |
4 participants
Dear Airflow maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
[AIRFLOW-1389] BigQueryOperator should support `createDisposition` - ASF JIRA
Description
BigQueryOperator should support
createDisposition.I have added a parameter for
configuration.query.createDisposition.