Fix error in seeding elastic log_id template#24960
Merged
ephraimbuddy merged 1 commit intoapache:mainfrom Jul 11, 2022
Merged
Conversation
ephraimbuddy
requested review from
ashb,
jedcunningham and
josh-fell
and removed request for
ashb
There was a mistake in seeding the elastic log id. We used hyphen instead of underscores
ephraimbuddy
force-pushed
the
fix-log-template-seeding
branch
from
4274bf5 to
827bca0
Compare
potiuk
approved these changes
Jul 11, 2022
Member
|
Does it mean 2.3.4 ? |
Contributor
Author
Yes. though not critical(I believe), so we can still wait |
jedcunningham
added a commit
to astronomer/airflow
that referenced
this pull request
Jul 11, 2022
This reverts commit c97f0b3.
jedcunningham
added
the
changelog:skip
jedcunningham
added a commit
that referenced
this pull request
Jul 11, 2022
) This reverts commit c97f0b3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a mistake in seeding the elastic log id. We used hyphens instead of underscores