Add dataset events to dataset api#25011
Closed
jedcunningham wants to merge 2 commits intoapache:mainfrom
Closed
Conversation
jedcunningham
added
changelog:skip
jedcunningham
force-pushed
the
dataset_events_api
branch
from
7f73edf to
0857f6b
Compare
bbovenzi
reviewed
Jul 13, 2022
| @provide_session | ||
| @format_parameters({'limit': check_limit}) | ||
| def get_dataset_events( | ||
| id, *, limit: int, offset: int = 0, order_by: str = "created_at", session: Session = NEW_SESSION |
Contributor
There was a problem hiding this comment.
instead of just ordering, it may be useful to be able to filter by a dag_id
bbovenzi
reviewed
Jul 13, 2022
| detail=f"The Dataset with id: `{id}` was not found", | ||
| ) | ||
|
|
||
| allowed_attrs = ['task_id', 'dag_id', 'run_id', 'map_index', 'created_at'] |
Contributor
There was a problem hiding this comment.
should we allow sorting by map_index alone? Practically, I feel like really this would at least combine with the task_id, right?
Member
Author
There was a problem hiding this comment.
I agree, generally, though we probably need to allow multiple order_by's and I don't want to intermix that here.
Contributor
There was a problem hiding this comment.
yeah, this is fine for now. I just wanted to bring it up for later.
bbovenzi
approved these changes
Jul 13, 2022
Member
Author
|
Closing in favor of #25039. |
eladkal
added
area:data-aware-scheduling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add api endpoint to get events for a dataset.