Convert example_ecs_fargate.py to an AIP-47 system test#25224
Convert example_ecs_fargate.py to an AIP-47 system test#25224ferruzzi wants to merge 2 commits intoapache:mainfrom
Conversation
|
Huh. Where did those come from.... 👀 Looks like the same tests are failing in main, so it's something that was changed in the last couple of days. I'm heading out for a mini roadtrip with the family, I'll try to figure this out on Monday if it's still a problem. |
have a great trip - nope. it looks like error when importing the tests :). But it can easily wait - no problem whatsoever :) |
Yeah, what I meant by that is when I rebase and check out main, those tests still fail. So we know:
Anyway, I'm home and I'll poke it today and see what I can find. 👍 [EDIT] Actually, I just rebased and these are all passing locally again on main when I run the same CI script but not in this branch. I'm quite confused by that, but but at least I know the issue is actually in this PR somewhere. |
a7f74c1 to
3667f6b
Compare
|
Closing while I sort this out. |
Follows the template set forward in #24643
Also cleans up and makes some required changes within the SystemTestContextBuilder to account for occasionally needing to split the imported variables such as a list of Subnets in this test.