Skip to content

Comments

[AIRFLOW-1543] Improve error message for incorrect fernet_key#2551

Closed
gtt116 wants to merge 1 commit intoapache:masterfrom
gtt116:master
Closed

[AIRFLOW-1543] Improve error message for incorrect fernet_key#2551
gtt116 wants to merge 1 commit intoapache:masterfrom
gtt116:master

Conversation

@gtt116
Copy link

@gtt116 gtt116 commented Aug 29, 2017

Dear Airflow maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    No UI changes, only some improvement for logging.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Just some trivial modification, no tests add, if necessary it could be done.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-io
Copy link

codecov-io commented Aug 29, 2017

Codecov Report

Merging #2551 into master will decrease coverage by 5.81%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2551      +/-   ##
==========================================
- Coverage   76.67%   70.85%   -5.82%     
==========================================
  Files         199      150      -49     
  Lines       16186    11585    -4601     
==========================================
- Hits        12410     8209    -4201     
+ Misses       3776     3376     -400
Impacted Files Coverage Δ
airflow/models.py 87.17% <66.66%> (-4.88%) ⬇️
airflow/operators/email_operator.py 0% <0%> (-100%) ⬇️
airflow/hooks/pig_hook.py 0% <0%> (-100%) ⬇️
airflow/operators/slack_operator.py 0% <0%> (-97.37%) ⬇️
airflow/operators/s3_file_transform_operator.py 0% <0%> (-96.23%) ⬇️
airflow/operators/redshift_to_s3_operator.py 0% <0%> (-95.46%) ⬇️
airflow/hooks/jdbc_hook.py 0% <0%> (-94.45%) ⬇️
airflow/executors/celery_executor.py 0% <0%> (-80.62%) ⬇️
airflow/hooks/S3_hook.py 22.27% <0%> (-72.05%) ⬇️
airflow/hooks/mssql_hook.py 6.66% <0%> (-66.67%) ⬇️
... and 199 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e703d6b...1126a50. Read the comment docs.



class Variable(Base):
class Variable(Base, LoggingMixin):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an un-related change....? Is it needed?

@tkaymak
Copy link
Contributor

tkaymak commented May 28, 2018

any update on this?

@ron819
Copy link
Contributor

ron819 commented Dec 10, 2018

@gtt116 can you rebase?

@ashb
Copy link
Member

ashb commented Jan 21, 2019

Fixed elsewhere

@ashb ashb closed this Jan 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants