AIP-47 - Migrate arangodb DAG to new design#25529
AIP-47 - Migrate arangodb DAG to new design#25529chethanuk wants to merge 1 commit intoapache:mainfrom
Conversation
josh-fell
left a comment
There was a problem hiding this comment.
Generally, these system tests should be self-contained. The DAG that will be run references ArangoDB documents and data that aren't created or available as part of the test in a resources/ directory as well as missing SQL files.
I would suggest taking a look at the Postgres provider system tests. Tables are created, inserted into, dropped all within the same test, and all SQL is available so it can be executed straight away as written.
Side note, it looks like the other __init__ files for the other providers are unrelated and not needed.
| .. exampleinclude:: /../../airflow/providers/arangodb/example_dags/example_arangodb.py | ||
| .. exampleinclude:: /../../tests/system/providers/arangodb/example_arangodb.py | ||
| :language: python | ||
| :start-after: [START howto_aql_operator_template_file_arangodb] |
There was a problem hiding this comment.
| :start-after: [START howto_aql_operator_template_file_arangodb] | |
| :dedent: 4 | |
| :start-after: [START howto_aql_operator_template_file_arangodb] |
Now that the START/END markers have been indented in the system test example DAG, this option should be added to the exampleinclude:: directives in the docs so the code snippets are rendered properly.
| .. exampleinclude:: /../../airflow/providers/arangodb/example_dags/example_arangodb.py | ||
| .. exampleinclude:: /../../tests/system/providers/arangodb/example_arangodb.py | ||
| :language: python | ||
| :start-after: [START howto_aql_sensor_arangodb] |
There was a problem hiding this comment.
| :start-after: [START howto_aql_sensor_arangodb] | |
| :dedent: 4 | |
| :start-after: [START howto_aql_sensor_arangodb] |
| .. exampleinclude:: /../../airflow/providers/arangodb/example_dags/example_arangodb.py | ||
| .. exampleinclude:: /../../tests/system/providers/arangodb/example_arangodb.py | ||
| :language: python | ||
| :start-after: [START howto_aql_sensor_template_file_arangodb] |
There was a problem hiding this comment.
| :start-after: [START howto_aql_sensor_template_file_arangodb] | |
| :dedent: 4 | |
| :start-after: [START howto_aql_sensor_template_file_arangodb] |
| .. exampleinclude:: /../../airflow/providers/arangodb/example_dags/example_arangodb.py | ||
| .. exampleinclude:: /../../tests/system/providers/arangodb/example_arangodb.py | ||
| :language: python | ||
| :start-after: [START howto_aql_operator_arangodb] |
There was a problem hiding this comment.
| :start-after: [START howto_aql_operator_arangodb] | |
| :dedent: 4 | |
| :start-after: [START howto_aql_operator_arangodb] |
| with DAG( | ||
| DAG_ID, | ||
| start_date=datetime(2021, 1, 1), | ||
| tags=['example'], |
There was a problem hiding this comment.
| tags=['example'], | |
| schedule_interval='@once', | |
| tags=['example'], |
Looks like this parameter is explicitly needed based on the AIP docs.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.