Coorect branch used for non-main builds#25545
Merged
potiuk merged 1 commit intoapache:mainfrom Aug 4, 2022
Merged
Conversation
Shell parameters should determine the branch based on environment variables so that main version of Breeze can properly build images in build-images.yml workflow. While CI/PROD params were ok, Shell Param was always using main and this failed PRs to v2-3-stable/test. This PR unifies branch selection to use env variables (which are properly set in CI).
Member
Author
|
Last thing to make non-brain PRs to work (will be useful for 2.4 branch when we have it). |
Member
Author
|
This is why https://github.com/apache/airflow/runs/7680474284?check_suite_focus=true failed. |
jedcunningham
approved these changes
Aug 4, 2022
potiuk
added a commit
that referenced
this pull request
Aug 5, 2022
Shell parameters should determine the branch based on environment variables so that main version of Breeze can properly build images in build-images.yml workflow. While CI/PROD params were ok, Shell Param was always using main and this failed PRs to v2-3-stable/test. This PR unifies branch selection to use env variables (which are properly set in CI). (cherry picked from commit 85e3b35)
potiuk
added a commit
that referenced
this pull request
Aug 5, 2022
Shell parameters should determine the branch based on environment variables so that main version of Breeze can properly build images in build-images.yml workflow. While CI/PROD params were ok, Shell Param was always using main and this failed PRs to v2-3-stable/test. This PR unifies branch selection to use env variables (which are properly set in CI). (cherry picked from commit 85e3b35)
ephraimbuddy
added
the
changelog:skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shell parameters should determine the branch based on environment
variables so that main version of Breeze can properly build images
in build-images.yml workflow.
While CI/PROD params were ok, Shell Param was always using main
and this failed PRs to v2-3-stable/test.
This PR unifies branch selection to use env variables (which are
properly set in CI).
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.