get dataset by uri instead of id in rest api#25770
Merged
bbovenzi merged 2 commits intoapache:mainfrom Aug 17, 2022
Merged
Conversation
bbovenzi
requested review from
ashb,
ephraimbuddy,
mik-laj and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
bbovenzi
force-pushed
the
get-dataset-by-uri
branch
from
a172ea0 to
bca98c1
Compare
bbovenzi
commented
Aug 17, 2022
| schema: | ||
| type: integer | ||
| type: string | ||
| format: path |
Contributor
Author
There was a problem hiding this comment.
This was the key piece to get strings with slashes in them to be accepted. We probably need to add this to a few other parts of the API
jedcunningham
approved these changes
Aug 17, 2022
bbovenzi
changed the title
jedcunningham
added
changelog:skip
eladkal
added
area:data-aware-scheduling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dataset.id is just an incrementing integer and shouldn't be revealed to the user. Instead, we should get a dataset by its uri.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.