Filter out non-editable apache-airflow from constraints.#25847
Merged
potiuk merged 1 commit intoapache:mainfrom Aug 20, 2022
Merged
Conversation
The constraint files should not contain apache-airflow. So far apache-airflow has been automatically filtered out by the fact that it has been an editable installation and we filtered out all editable and file installations from `pip freeze`. However as of ~12 August 2022, likely setuptools change triggered a slight behaviour change when `eager-upgrade` installation of providers from PyPi was run in the CI image. Previously airflow remained an editable install, but as of 12th of August, such an installation causes removal of editable airlfow install and reinstalls it in non-editable mode. While this change is somewhat confusing, we have to protect against it and remove apache-airflow from `pip freeze` also in non-editable mode.
ephraimbuddy
approved these changes
Aug 20, 2022
potiuk
deleted the
filter-out-non-editable-apache-airflow-from-constraints
branch
potiuk
added a commit
that referenced
this pull request
Aug 20, 2022
The constraint files should not contain apache-airflow. So far apache-airflow has been automatically filtered out by the fact that it has been an editable installation and we filtered out all editable and file installations from `pip freeze`. However as of ~12 August 2022, likely setuptools change triggered a slight behaviour change when `eager-upgrade` installation of providers from PyPi was run in the CI image. Previously airflow remained an editable install, but as of 12th of August, such an installation causes removal of editable airlfow install and reinstalls it in non-editable mode. While this change is somewhat confusing, we have to protect against it and remove apache-airflow from `pip freeze` also in non-editable mode. (cherry picked from commit cdbad44)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The constraint files should not contain apache-airflow. So far
apache-airflow has been automatically filtered out by the fact that it
has been an editable installation and we filtered out all editable
and file installations from
pip freeze.However as of ~12 August 2022, likely setuptools change triggered
a slight behaviour change when
eager-upgradeinstallation ofproviders from PyPi was run in the CI image. Previously airflow
remained an editable install, but as of 12th of August, such an
installation causes removal of editable airlfow install and
reinstalls it in non-editable mode. While this change is somewhat
confusing, we have to protect against it and remove apache-airflow
from
pip freezealso in non-editable mode.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.