Remove implementation of __hash__ method on DatasetEvent#25889
Merged
kaxil merged 1 commit intoapache:mainfrom Aug 23, 2022
Merged
Remove implementation of __hash__ method on DatasetEvent#25889kaxil merged 1 commit intoapache:mainfrom
__hash__ method on DatasetEvent#25889kaxil merged 1 commit intoapache:mainfrom
Conversation
It is not used (we know this because it's currently defined with attrs that do not exist (created_at). We could fix this, but it's somewhat questionable that dataset + timestamp is the "right" choice, so, since it's not used, better not to implement.
uranusjr
approved these changes
Aug 23, 2022
kaxil
approved these changes
Aug 23, 2022
jedcunningham
added
changelog:skip
eladkal
added
area:data-aware-scheduling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not used (we know this because it's currently defined with attrs that do not exist, namely created_at). We could fix this, but it's somewhat questionable that dataset + timestamp is the "right" choice, so, since it's not used, better not to implement.