Remove implementation of __eq__ method from DatasetEvent#25907
Merged
uranusjr merged 2 commits intoapache:mainfrom Aug 24, 2022
Merged
Remove implementation of __eq__ method from DatasetEvent#25907uranusjr merged 2 commits intoapache:mainfrom
__eq__ method from DatasetEvent#25907uranusjr merged 2 commits intoapache:mainfrom
Conversation
Given that in the future we might allow registering of dataset events from other systems, dataset_id + timestamp might not be quite enough grain. So rather than have to make a "breaking" change to `__eq__` in the future, it would be better to avoid defining it now. It's only used in a test.
dstandish
force-pushed
the
remove-eq-method
branch
from
39dbe96 to
f8afef4
Compare
dstandish
changed the title
__eq__ method from DatasetEvent__eq__ method from DatasetEvent
dstandish
force-pushed
the
remove-eq-method
branch
from
f8afef4 to
323ba99
Compare
dstandish
force-pushed
the
remove-eq-method
branch
from
323ba99 to
6f3874f
Compare
potiuk
approved these changes
Aug 23, 2022
jedcunningham
added
changelog:skip
eladkal
added
area:data-aware-scheduling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that in the future we might allow registering of dataset events from other systems, dataset_id + timestamp might not be quite enough grain. So rather than have to make a "breaking" change to
__eq__in the future, it would be better to avoid defining it now. It's only used in a test.