Rename DatasetDagRef to DagScheduleDatasetReference#25920
Rename DatasetDagRef to DagScheduleDatasetReference#25920dstandish merged 3 commits intoapache:mainfrom
Conversation
dstandish
requested review from
XD-DENG,
ashb,
bbovenzi,
ephraimbuddy,
kaxil,
mik-laj and
ryanahamilton
as code owners
boring-cyborg
bot
added
area:API
dstandish
changed the title
There was a problem hiding this comment.
Same as other PR, wdyt about DatasetConsumer or DatasetConsumerDag instead?
There was a problem hiding this comment.
well, i guess the people have spoken
There was a problem hiding this comment.
i'll just mention though... the reason i thought it makes sense to put Dag first, is cus it's the reference from dag to dataset.
so if we didn't have to specify type of reference (i.e. consumer vs producer) then it would be a pretty easy choice i think.... we'd just call it dag_dataset since it's just a mapping from dag to dataset.
and so i figured, just add a suffix indicating type: dag_dataset_consumer
but, i guess another way to think about it is, not so much as a mapping table, but more as an entity unto itself, e.g. a DatasetConsumer entity of type Dag.... which... i guess is how y'all are thinking about it.
There was a problem hiding this comment.
Like the other one, maybe DatasetConsumingDag instead?
There was a problem hiding this comment.
actually had other thought please see thread #25919 (comment)
dstandish
changed the title
dstandish
force-pushed
the
dag-dataset-consumer-rename
branch
from
591c954 to
2280431
Compare
dstandish
changed the title
dstandish
changed the title
dstandish
force-pushed
the
dag-dataset-consumer-rename
branch
from
2280431 to
4d45006
Compare
Makes more sense to name with `<thing doing the referencing>_<thing that is referenced>`.
dstandish
force-pushed
the
dag-dataset-consumer-rename
branch
from
4d45006 to
6173db4
Compare
jedcunningham
added
changelog:skip
8 participants
Makes more sense to name with
<thing doing the referencing>_<thing that is referenced>.