Do not include mypy volume by default#25958
Merged
potiuk merged 1 commit intoapache:mainfrom Aug 26, 2022
Merged
Conversation
Member
Author
|
cc: @ferruzzi |
Contributor
|
Thanks for this. 👍 (non-binding +1 ? :P ) |
potiuk
force-pushed
the
fix-mypy-volume-for-regular-breeze-commands
branch
from
37266a3 to
fffff4f
Compare
potiuk
force-pushed
the
fix-mypy-volume-for-regular-breeze-commands
branch
from
fffff4f to
1b57a0a
Compare
MyPy volume was included by default in shell command, but it is not needed and might lead to missing mypy-cache volume problem. It is useful for debugging mypy problems so it is still useful to have it as an option of shell command.
potiuk
force-pushed
the
fix-mypy-volume-for-regular-breeze-commands
branch
from
1b57a0a to
fd58b99
Compare
josh-fell
approved these changes
Aug 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MyPy volume was included by default in shell command, but it is
not needed and might lead to missing mypy-cache volume problem.
It is useful for debugging mypy problems so it is still useful to
have it as an option of shell command.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.