Remove limitation to pull latest images.#26086
Merged
potiuk merged 1 commit intoapache:mainfrom Aug 31, 2022
Merged
Conversation
The apache#25380 restored regular pushing of "latest" images to ghcr.io (after some period where we did not do it, because caching is now solved differently - using separate "cache" images for each of the architectures). We restored it because codespaces were pulling the latest image rather than rebuilding the images using cache. However we have not removed the protection against pulling the latest image (because it could be old). This PR removes the - now unnecessary - protection.
mik-laj
approved these changes
Aug 31, 2022
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Sep 1, 2022
The `pull` commands of Breeze ci-image and prod-image got the possibility of pulling latest image in apache#26086 but the --image-tag remained as required. This PR brings back the --image-tag to fall back to 'latest' for pull commands.
potiuk
added a commit
that referenced
this pull request
Sep 1, 2022
The `pull` commands of Breeze ci-image and prod-image got the possibility of pulling latest image in #26086 but the --image-tag remained as required. This PR brings back the --image-tag to fall back to 'latest' for pull commands.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #25380 restored regular pushing of "latest" images to ghcr.io
(after some period where we did not do it, because caching
is now solved differently - using separate "cache" images for
each of the architectures). We restored it because codespaces
were pulling the latest image rather than rebuilding the images using
cache. However we have not removed the protection against pulling
the latest image (because it could be old).
This PR removes the - now unnecessary - protection.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.