Skip to content

[AIRFLOW-1619] Add poll_sleep parameter to GCP dataflow operator#2612

Closed
TJBIII wants to merge 2 commits intoapache:masterfrom
TJBIII:gcp_dataflow_poll_sleep
Closed

[AIRFLOW-1619] Add poll_sleep parameter to GCP dataflow operator#2612
TJBIII wants to merge 2 commits intoapache:masterfrom
TJBIII:gcp_dataflow_poll_sleep

Conversation

@TJBIII
Copy link
Contributor

@TJBIII TJBIII commented Sep 18, 2017

Dear Airflow maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes: Add parameter to set the time in seconds to sleep between polling GCP for the dataflow job status while the job is in the JOB_STATE_RUNNING state. Allows for a more reasonable poll interval than the previously hard coded 10 seconds for long running jobs.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason: Added to tests/contrib/operators/test_dataflow_operator.py

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@codecov-io
Copy link

codecov-io commented Sep 18, 2017

Codecov Report

Merging #2612 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2612      +/-   ##
==========================================
- Coverage    70.7%   70.69%   -0.01%     
==========================================
  Files         150      150              
  Lines       11630    11630              
==========================================
- Hits         8223     8222       -1     
- Misses       3407     3408       +1
Impacted Files Coverage Δ
airflow/models.py 87.1% <0%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f136c5b...11fa286. Read the comment docs.

@criccomini
Copy link
Contributor

+1 LGTM

@asfgit asfgit closed this in 1c5b0f5 Sep 18, 2017
mrares pushed a commit to mrares/incubator-airflow that referenced this pull request Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants