Replace spelling wordlist sorting with Python#26138
Merged
potiuk merged 2 commits intoapache:mainfrom Sep 4, 2022
Merged
Conversation
potiuk
force-pushed
the
sort-spelling-wordlist-in-python
branch
from
83ce772 to
e3c0419
Compare
Member
Author
|
Not only replace the sorting with Python but also makes it case-insensitive (but stable) which makes it easier to find where to insert the word (I always struggled with casing there). |
potiuk
changed the title
mik-laj
reviewed
Sep 2, 2022
potiuk
force-pushed
the
sort-spelling-wordlist-in-python
branch
from
e3c0419 to
1c7cedb
Compare
Member
Author
|
Removed :) |
uranusjr
reviewed
Sep 3, 2022
potiuk
force-pushed
the
sort-spelling-wordlist-in-python
branch
from
acc4d00 to
3359173
Compare
mik-laj
approved these changes
Sep 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #26020
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.