Fail "early build cache" if breeze shell command is not quick#26150
Merged
potiuk merged 1 commit intoapache:mainfrom Sep 4, 2022
Merged
Conversation
eladkal
approved these changes
Sep 4, 2022
This is a follow-up after apache#26148 where we found out that basic breeze command took far more time than it should when user answered "yes" to rebuild the image. This PR adds `--max-time` parameter to `breze shell` command which forces "exit" to be executed as command and fails if the command does not complete in time specified. This command is run in "early build cache" so failure there will not fail the whole build (the job has "continue on error" set), but we will see the "red" status of the `main` workflow in case the build takes longer than 120 seconds - indicating that the build takes too long. We only run it for `amd` images because if we have a problem there, we will have similar problem in arm images. We make sure to clear the docker cache before the command is run to make sure that it runs in "clean" state.
potiuk
force-pushed
the
check-that-fresh-breeze-image-building-is-fast
branch
from
4460b07 to
eceec87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up after #26148 where we found out that basic
breeze command took far more time than it should when user
answered "yes" to rebuild the image.
This PR adds
--max-timeparameter tobreze shellcommand whichforces "exit" to be executed as command and fails if the command
does not complete in time specified.
This command is run in "early build cache" so failure there will
not fail the whole build (the job has "continue on error" set),
but we will see the "red" status of the
mainworkflow in casethe build takes longer than 120 seconds - indicating that the
build takes too long.
We only run it for
amdimages because if we have a problemthere, we will have similar problem in arm images.
We make sure to clear the docker cache before the command is run
to make sure that it runs in "clean" state.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.