Fix intermittently failing tests for SFTPOperator#26685
Merged
potiuk merged 1 commit intoapache:mainfrom Sep 26, 2022
Merged
Conversation
pauldalewilliams
force-pushed
the
fix-sftpoperator-tests
branch
from
5cd1dd8 to
28cb401
Compare
potiuk
approved these changes
Sep 26, 2022
Member
What a dedication :). Thanks a lot for those :) |
Contributor
Author
Haha, it was the only way I felt I could be sure I wasn't just getting lucky! 10 times in a row seemed like it was good enough, but I did another 30 just to be sure. 😀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SFTPOperator tests that are intermittently failing (see #26666 as an example)
I think more refactoring of these tests could be a good thing, but I'm not comfortable enough with testing yet to feel confident in making those changes. I believe the changes I made here keep the original tests as close to their current structure as possible while addressing the issues that cause them to fail intermittently (depending on side effects of previous tests).
Edit: Forgot to mention I ran the tests locally 40 times to make sure this actually resolves the issues and all 40 runs were successful.