Skip to content

Give a clue what the 'ds' variable is#2679

Closed
tgs wants to merge 1 commit intoapache:masterfrom
tgs:patch-1
Closed

Give a clue what the 'ds' variable is#2679
tgs wants to merge 1 commit intoapache:masterfrom
tgs:patch-1

Conversation

@tgs
Copy link
Contributor

@tgs tgs commented Oct 10, 2017

It's not explained anywhere else in the tutorial...

Sorry, I'm not going to make a JIRA ticket for a three word documentation improvement :-P

It's not explained anywhere else in the tutorial...
@codecov-io
Copy link

codecov-io commented Oct 10, 2017

Codecov Report

Merging #2679 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2679   +/-   ##
=======================================
  Coverage   71.78%   71.78%           
=======================================
  Files         154      154           
  Lines       11808    11808           
=======================================
  Hits         8476     8476           
  Misses       3332     3332

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe715c...addeaee. Read the comment docs.

@walkoss
Copy link
Contributor

walkoss commented Oct 24, 2017

Hi @tgs

This variable is "explained" here in the tutorial.

@tgs
Copy link
Contributor Author

tgs commented Oct 24, 2017

That's the API reference, not the tutorial. The reason I suggested the change is that I had no idea what the variable was when looking in the tutorial, and I had to find that page to get an explanation. The API reference isn't the first google result for "apache airflow ds", and it's hard to Ctrl-F find "ds" on that page because "ds" occurs in lots of other words.

@walkoss
Copy link
Contributor

walkoss commented Oct 24, 2017

You right then. Maybe you can note that it's the execution date to be more specific.

asfgit pushed a commit that referenced this pull request Nov 2, 2017
It's not explained anywhere else in the
tutorial...

Closes #2679 from tgs/patch-1

(cherry picked from commit 2fef915)
Signed-off-by: Bolke de Bruin <bolke@xs4all.nl>
@asfgit asfgit closed this in 2fef915 Nov 2, 2017
Acehaidrey pushed a commit to Acehaidrey/incubator-airflow that referenced this pull request Jan 19, 2018
It's not explained anywhere else in the
tutorial...

Closes apache#2679 from tgs/patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants