More resilient test for secrets masker#27335
Merged
potiuk merged 1 commit intoapache:mainfrom Oct 27, 2022
Merged
Conversation
The test expected exact stack trace, but we really want to check if the stacktrace contains masked passwords at all levels of context. This PR makes the test more resilient to any changes in stacktrace.
potiuk
requested review from
Taragolis,
ashb,
dstandish,
eladkal,
ephraimbuddy and
jedcunningham
Taragolis
approved these changes
Oct 27, 2022
Contributor
Taragolis
left a comment
Taragolis
left a comment
There was a problem hiding this comment.
This also looks more simpler now
jedcunningham
approved these changes
Oct 27, 2022
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Oct 28, 2022
Seems that the number of times user is printed in stack trace depend on Python version. The fix in apache#27335 seems to only have worked for Python 3.10 with the 1.0.0 of exceptiongroup the stack trace has less stack levels.
potiuk
added a commit
that referenced
this pull request
Oct 28, 2022
Seems that the number of times user is printed in stack trace depend on Python version. The fix in #27335 seems to only have worked for Python 3.10 with the 1.0.0 of exceptiongroup the stack trace has less stack levels.
ephraimbuddy
added
type:misc/internal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test expected exact stack trace, but we really want to check if the stacktrace contains masked passwords at all levels of context.
This PR makes the test more resilient to any changes in stacktrace.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.