Skip to content

[AIRFLOW-1771] Rename heartbeat to avoid confusion#2743

Closed
saguziel wants to merge 1 commit intoapache:masterfrom
saguziel:aguziel-heartbeat
Closed

[AIRFLOW-1771] Rename heartbeat to avoid confusion#2743
saguziel wants to merge 1 commit intoapache:masterfrom
saguziel:aguziel-heartbeat

Conversation

@saguziel
Copy link
Contributor

@saguziel saguziel commented Oct 31, 2017

Dear Airflow maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
@aoen @bolkedebruin

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes: People confuse "Boom" with something going bad (Boom sounds like an explosion, not a heartbeat). We should rename this to avoid confusion

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason: n/a

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

will add the jira issue in a sec

@saguziel saguziel changed the title [AIRFLOW-xxxx] Rename heartbeat to avoid confusion [AIRFLOW-1771] Rename heartbeat to avoid confusion Oct 31, 2017
@aoen
Copy link
Contributor

aoen commented Oct 31, 2017

LGTM

@codecov-io
Copy link

codecov-io commented Oct 31, 2017

Codecov Report

Merging #2743 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2743      +/-   ##
==========================================
+ Coverage      73%   73.07%   +0.07%     
==========================================
  Files         155      155              
  Lines       11835    11835              
==========================================
+ Hits         8640     8649       +9     
+ Misses       3195     3186       -9
Impacted Files Coverage Δ
airflow/jobs.py 79.87% <100%> (+0.26%) ⬆️
airflow/utils/helpers.py 56.32% <0%> (+2.87%) ⬆️
airflow/task_runner/bash_task_runner.py 100% <0%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44710d7...0f28dd0. Read the comment docs.

@asfgit asfgit closed this in 6b8fe98 Oct 31, 2017
saguziel added a commit to saguziel/incubator-airflow that referenced this pull request Oct 31, 2017
Closes apache#2743 from saguziel/aguziel-heartbeat
Acehaidrey pushed a commit to Acehaidrey/incubator-airflow that referenced this pull request Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants