Code quality improvements on sagemaker operators/hook#27453
Merged
eladkal merged 4 commits intoapache:mainfrom Nov 4, 2022
Merged
Code quality improvements on sagemaker operators/hook#27453eladkal merged 4 commits intoapache:mainfrom
eladkal merged 4 commits intoapache:mainfrom
Conversation
boring-cyborg
bot
added
area:providers
provider:amazon
vandonr-amz
commented
Nov 1, 2022
Contributor
Author
There was a problem hiding this comment.
unittest.TestCase is incompatible with @pytest.mark.parametrize which I'm using below.
Given the fact that this inheritance was unnecessary, I simply removed it.
Contributor
There was a problem hiding this comment.
Replace unittest classes by native class always welcome.
Contributor
Author
There was a problem hiding this comment.
mock is necessary but default behavior doesn't need to be changed.
Comment on lines
+53
to
54
Contributor
Author
There was a problem hiding this comment.
merging 2 tests in one
vandonr-amz
force-pushed
the
vandonr/cleaning
branch
from
356c81c to
f783cd3
Compare
o-nikolas
approved these changes
Nov 3, 2022
eladkal
approved these changes
Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No functional change here. I'm working on some new features in those files and wanted to extract the cosmetic changes in a separate PR to ease reviewing.
self.config = configis done in the base class ctor)