Skip to content

Comments

Added custom environment variables to statsd#28034

Closed
RagingPuppies wants to merge 7 commits intoapache:mainfrom
RagingPuppies:statsd_custom_env
Closed

Added custom environment variables to statsd#28034
RagingPuppies wants to merge 7 commits intoapache:mainfrom
RagingPuppies:statsd_custom_env

Conversation

@RagingPuppies
Copy link

Hi,
This is not related to any issue, all airflow components have the option to add custom env to their docker container except statsd, I've just added the same functionality and tested the chart in debug mode. (as I don't think the unit tests have any relation to the helm charts.)

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Dec 1, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 1, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

subPath: mappings.yml
{{- if .Values.statsd.env}}
env:
{{- include "container_extra_envs" (list . .Values.statsd.env) | indent 10 }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this isn't an Airflow container, we don't need to use this helper here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jedcunningham as Flower is not an airflow container as well, but it did use the same code, don't you think it should be aligned?

{{- include "container_extra_envs" (list . .Values.flower.env) | indent 10 }}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference is flower is started via the Airflow cli, and this run in a completely separate image that doesn't even have Airflow.

RagingPuppies and others added 3 commits December 2, 2022 11:36
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
@potiuk
Copy link
Member

potiuk commented Dec 18, 2022

Are you still working on it @RagingPuppies ? If so - it needs rebase/conflict resolving

@RagingPuppies
Copy link
Author

yes, @potiuk didn't have the time, pushed a new commit to fix @jedcunningham rejects.

@potiuk
Copy link
Member

potiuk commented Jan 17, 2023

Some conflicts still need to be solved @RagingPuppies now

@github-actions
Copy link

github-actions bot commented Mar 4, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Mar 4, 2023
@github-actions github-actions bot closed this Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants