Skip to content

Conversation

@Swalloow
Copy link
Contributor

@Swalloow Swalloow commented Dec 1, 2017

Change EmrBaseSensor NON_TERMINAL_STATES and FAILED_STATE to list
EmrJobFlowSensor consideres Cancelled step as Successful

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

@gonzalodiaz
Copy link

+1 we are having this very same issue and is causing headaches in production.

To add my Use Case

  • We trigger the Cluster creation
  • It failed due to a Validation Error
  • The Cluster start shutting down and the Steps are created
  • Steps are marked as Cancelled
  • Cluster shuts down.

@bolkedebruin
Copy link
Contributor

Please add a test and provide a commit message following the commit guidelines. Thanks!

@Swalloow
Copy link
Contributor Author

Swalloow commented Dec 6, 2017

@bolkedebruin Okay then I will add another new pull request :)

@Swalloow Swalloow closed this Dec 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants