Initial support for SAS community provider#28503
Initial support for SAS community provider#28503AndrewShakinovsky-SAS wants to merge 2 commits intoapache:mainfrom sassoftware:initial
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
| def create_session_for_connection(connection_name: str): | ||
| print(f"Creating session for connection named {connection_name}") |
There was a problem hiding this comment.
We use Hooks for this purpose: https://airflow.apache.org/docs/apache-airflow/stable/concepts/connections.html#hooks which is also provide nice ability to create Connection into the UI: https://airflow.apache.org/docs/apache-airflow/stable/howto/connection.html#custom-connection-types
| # disable insecure HTTP requests warnings | ||
| urllib3.disable_warnings(InsecureRequestWarning) |
There was a problem hiding this comment.
Hmm.. is this globally disable all InsecureRequestWarning?
|
|
||
| print(f"Executing SAS job: {self.job_name}") |
There was a problem hiding this comment.
Use self.log.{log_level} instead of print. All subclasses of BaseOperator and BaseHook already have attribute log
2 participants
Initial support for SAS community provider
Adds:
SAS Studio Flow Operator
SAS Job Execution Operator
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.