Minor typos and doc-strings added#28607
Closed
stamixthereal wants to merge 4 commits intoapache:mainfrom
stamixthereal:main
Closed
Minor typos and doc-strings added#28607stamixthereal wants to merge 4 commits intoapache:mainfrom stamixthereal:main
stamixthereal wants to merge 4 commits intoapache:mainfrom
stamixthereal:main
Conversation
added 3 commits
December 27, 2022 17:48
A minor typos were found in the code docstrings and comments and were fixed in this commit.
A minor typos were found in the code docstrings and comments and were fixed in this commit.
A minor typos were found in the code docstrings and comments and were fixed in this commit.
stamixthereal
requested review from
ashb,
ephraimbuddy,
mik-laj,
potiuk and
uranusjr
as code owners
boring-cyborg
bot
added
area:API
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
uranusjr
reviewed
Dec 28, 2022
| new_cls = super().__new__(cls, name, bases, namespace, **kwargs) | ||
| with contextlib.suppress(KeyError): | ||
| # Update the partial descriptor with the class method so it call call the actual function (but let | ||
| # Update the partial descriptor with the class method, so it call the actual function (but let |
Member
There was a problem hiding this comment.
Suggested change
| # Update the partial descriptor with the class method, so it call the actual function (but let | |
| # Update the partial descriptor with the class method, so it calls the actual function (but let |
|
|
||
| if downstream: | ||
| tasks += [t.task_id for t in self.get_flat_relatives(upstream=False)] | ||
| tasks += [t.task_id for t in self.get_flat_relatives()] |
Member
There was a problem hiding this comment.
The default value of upstream is False, and we need to keep it for backward compatibility, but I’d prefer to keep it at the call sites for explicitness.
Comment on lines
-66
to
+69
| template_ext: Sequence[str] = (".sh",) | ||
| template_ext: Sequence[str] = ( | ||
| ".sh", | ||
| ".bash", | ||
| ) |
Member
There was a problem hiding this comment.
This looks unrelated? I’m not against its addition, but it should be done in a separate PR.
Comment on lines
+40
to
+44
| Args: | ||
| classname: The classname to translate. | ||
|
|
||
| Returns: | ||
| The translated pytest selector. |
Member
There was a problem hiding this comment.
We generally use Sphinx-style derivatives instead of Google-style. See other functions for examples.
Comment on lines
-42
to
+71
| context = Path.cwd() | ||
|
|
||
| context = str(Path.cwd()) | ||
| parts = classname.split(".") | ||
| num_parts = len(parts) | ||
| i = 0 | ||
|
|
||
| for i, component in enumerate(parts): | ||
| candidate = context / component | ||
| while i < num_parts: | ||
| component = parts[i] | ||
| candidate = context + "/" + component | ||
|
|
||
| if candidate.is_dir(): | ||
| context = candidate | ||
| continue | ||
| candidate = context / (component + ".py") | ||
| if candidate.is_file(): | ||
| if Path(candidate).is_dir(): | ||
| context = candidate | ||
| i += 1 | ||
| elif Path(candidate + ".py").is_file(): | ||
| context = candidate + ".py" | ||
| i += 1 | ||
| break | ||
| break | ||
| else: | ||
| break | ||
|
|
||
| parts = parts[i:] | ||
|
|
||
| val = str(context.relative_to(Path.cwd())) | ||
| val = str(Path(context).relative_to(Path.cwd())) |
Member
There was a problem hiding this comment.
Why is this particular function rewritten so extensively? This should be done in a different PR, and honestly I’m not sure the rewrite is an improvement to begine with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor typos were found in the code docstrings and comments and were fixed in this commit:
airflow/api/client/json_client.pyairflow/models/baseoperator.py.bashextension toairflow/providers/ssh/operators/ssh.pyscripts/ci/testing/summarize_junit_failures.py