[AIRFLOW-1912] airflow.processor should not propagate logging#2871
Closed
bolkedebruin wants to merge 1 commit intoapache:masterfrom
Closed
[AIRFLOW-1912] airflow.processor should not propagate logging#2871bolkedebruin wants to merge 1 commit intoapache:masterfrom
bolkedebruin wants to merge 1 commit intoapache:masterfrom
Conversation
The root logger will write to stdout. If redirection is used which is the case for processors and task runs (not runners) this can end up in an endless loop in case propagation is True.
Codecov Report
@@ Coverage Diff @@
## master #2871 +/- ##
==========================================
- Coverage 74.04% 73.96% -0.09%
==========================================
Files 160 160
Lines 12157 12157
==========================================
- Hits 9002 8992 -10
- Misses 3155 3165 +10
Continue to review full report at Codecov.
|
5 tasks
|
lgtm! good catch. |
jgao54
approved these changes
Dec 12, 2017
Acehaidrey
pushed a commit
to Acehaidrey/incubator-airflow
that referenced
this pull request
Jan 19, 2018
The root logger will write to stdout. If redirection is used which is the case for processors and task runs (not runners) this can end up in an endless loop in case propagation is True. Closes apache#2871 from bolkedebruin/AIRFLOW-1912
hougs
pushed a commit
to stitchfix/incubator-airflow
that referenced
this pull request
Jun 29, 2018
The root logger will write to stdout. If redirection is used which is the case for processors and task runs (not runners) this can end up in an endless loop in case propagation is True. Closes apache#2871 from bolkedebruin/AIRFLOW-1912
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
JIRA
Description
The root logger will write to stdout. If redirection is used
which is the case for processors and task runs (not runners)
this can end up in an endless loop in case propagation is True.
Tests
Config dependent.
Commits
My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
[=X] Passes
git diff upstream/master -u -- "*.py" | flake8 --diff@TrevorEdwards @jgao54 @Fokko