Remove @pytest.mark.quarantined from stable quarantine tests#28767
Remove @pytest.mark.quarantined from stable quarantine tests#28767potiuk merged 1 commit intoapache:mainfrom
@pytest.mark.quarantined from stable quarantine tests#28767Conversation
|
Cool. I think we shoudl do it a "bit" gradually (and let them run for a few days after merge). This will be helpful to narrow down the problem in case some of the tests introduce side-effect, to be able to determine which ones it is more easily. |
4f16be5 to
3a24f2c
Compare
|
Rebased them to re-run and re-check if they are repeatably stable as well. |
3a24f2c to
e636766
Compare
@pytest.mark.quarantined from tests@pytest.mark.quarantined from remaining quarantine tests
e636766 to
9e4a669
Compare
|
And rebased them with public runners too. |
|
@Taragolis -> https://github.com/apache/airflow/actions/runs/3864325055/jobs/6587088003 - seems that at least test_process_sigterm_works_with_retries is flaky on public runners ... |
|
@potiuk I hope it just flaky test and not something wrong with callback mechanism. |
|
I can't reproduce this error locally but I have an idea what could possible wrong Potentially callback might acquire lock airflow/tests/jobs/test_local_task_job.py Lines 779 to 784 in ce67786 After it checked in test case airflow/tests/jobs/test_local_task_job.py Lines 803 to 805 in ce67786 However locally I do not have this behaviour. I only could emulate it by adding |
9e4a669 to
82bcd48
Compare
|
And ... this test failed again 😞 |
|
Yeah. I think we could merge the others and leave that one as the last - I might also be able to take a look at it shortly (this is kinda what I was expecting and that's why I wanted to do it gradually) :) |
|
Yeah, let me revert quarantined mark for this test. I just think about what we tried to test here:
|
82bcd48 to
b9ff72c
Compare
@pytest.mark.quarantined from remaining quarantine tests@pytest.mark.quarantined from stable quarantine tests
b9ff72c to
58a6fb6
Compare
58a6fb6 to
1c8c520
Compare
|
One more rebase just in case... |
1c8c520 to
fadb23d
Compare
|
@potiuk looks like this tests stable. We would know more about stability after we merge it 🤣 |
|
Let's |
related: #28658
Currently all tests pass either local run or quarantined pipeline in CI. I've just remove flag from all test for check in all possible backends.
Most of the issues in the past related to MySQL 5.7 which almost reach EOL, however quarantined pipeline run only with SQLite backend.
Update
After couple runs we found that only tests/executors/test_celery_executor.py::TestLocalTaskJob::test_process_sigterm_works_with_retries is still flaky