Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
DecoratedOperatordecorators.base
21b839f to
673044a
Compare
| return_value = super().execute(context) | ||
| return_value: RV = super().execute(context) |
There was a problem hiding this comment.
Not sure if you can do this, CI will tell.
There was a problem hiding this comment.
If we use a TypeVar bound to the variables listed in my comment below, we could maybe use the following instead:
return_value: Dataset | list | dict = super().execute(context)
|
Fails at |
|
I have a different thought. Why do we need to return |
This is purely to improve types, but is not required as airflow isn't using |
|
So my point is, we can make the improvement moot by slightly changing how the code is written (without changing functionalities) |
|
Sure I can revert this part to |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
The usage of a
TypeVarseems more appropriate to me here^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.