Skip to content

Add samba hook copyfile functionality#28923

Closed
venufix wants to merge 6 commits intoapache:mainfrom
venufix:smb-hook-additional-functionalities
Closed

Add samba hook copyfile functionality#28923
venufix wants to merge 6 commits intoapache:mainfrom
venufix:smb-hook-additional-functionalities

Conversation

@venufix
Copy link

@venufix venufix commented Jan 13, 2023


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Jan 13, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@venufix venufix changed the title Added samba hook remove & copyfile functionalities Add samba hook copyfile functionality Jan 14, 2023
Copy link
Contributor

@Taragolis Taragolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Static checks failed, please follow this Guide
  • Tests need to be fixed

)
@wraps(smbclient.copyfile)
def copyfile(self, src, dst):
return smbclient.copyfile(self.__join_path(src), self.__join_path(dst), **self._conn_kwargs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return smbclient.copyfile(self.__join_path(src), self.__join_path(dst), **self._conn_kwargs)
return smbclient.copyfile(self._join_path(src), self._join_path(dst), **self._conn_kwargs)

@Taragolis
Copy link
Contributor

@venufix, do you have a plan to continue work on this PR?

@venufix
Copy link
Author

venufix commented Feb 18, 2023

Unfortunately no, found another solution you fan actually get the samba client args from the hook and run the function

@Taragolis
Copy link
Contributor

Unfortunately no, found another solution you fan actually get the samba client args from the hook and run the function

No problem at all.

@Taragolis Taragolis closed this Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants