introduce base class for EKS sensors#29053
Merged
o-nikolas merged 5 commits intoapache:mainfrom Jan 26, 2023
Merged
Conversation
boring-cyborg
bot
added
area:providers
provider:amazon
Contributor
|
@ferruzzi as our resident EKS expert, do you have time to take a look? |
ferruzzi
approved these changes
Jan 25, 2023
Contributor
ferruzzi
left a comment
ferruzzi
left a comment
There was a problem hiding this comment.
Left a non-blocking thought. Otherwise I like it. I love seeing commits that reduce linecount!
o-nikolas
approved these changes
Jan 26, 2023
58 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
most of the EKS sensors do the same thing, this can be grouped in one base class, a bit like what was done here
https://github.com/apache/airflow/blob/main/airflow/providers/amazon/aws/sensors/sagemaker.py#L33