[AIRFLOW-1958] Add **kwargs to send_email#2908
Closed
ms32035 wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2908 +/- ##
=======================================
Coverage 73.27% 73.27%
=======================================
Files 160 160
Lines 12196 12196
=======================================
Hits 8937 8937
Misses 3259 3259
Continue to review full report at Codecov.
|
Contributor
Author
|
can this be merged? I plan to expand the sendgrid backend basing on this |
Contributor
|
@criccomini could you help on merging this PR? |
Contributor
|
lgtm! |
Acehaidrey
pushed a commit
to Acehaidrey/incubator-airflow
that referenced
this pull request
Jan 19, 2018
Closes apache#2908 from ms32035/email_kwargs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA
Description
Tests
Commits
My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
Passes
git diff upstream/master -u -- "*.py" | flake8 --diff