Skip to content

[AIRFLOW-1958] Add **kwargs to send_email#2908

Closed
ms32035 wants to merge 1 commit intoapache:masterfrom
ms32035:email_kwargs
Closed

[AIRFLOW-1958] Add **kwargs to send_email#2908
ms32035 wants to merge 1 commit intoapache:masterfrom
ms32035:email_kwargs

Conversation

@ms32035
Copy link
Copy Markdown
Contributor

@ms32035 ms32035 commented Dec 29, 2017

JIRA

Description

  • **kwargs added to email function definitions. This can be used with custom backends

Tests

  • Covered by existing cases (at least should be)

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"
  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #2908 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2908   +/-   ##
=======================================
  Coverage   73.27%   73.27%           
=======================================
  Files         160      160           
  Lines       12196    12196           
=======================================
  Hits         8937     8937           
  Misses       3259     3259
Impacted Files Coverage Δ
airflow/utils/email.py 97.4% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7c2f71...88dff65. Read the comment docs.

Copy link
Copy Markdown
Contributor

@fenglu-db fenglu-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ms32035
Copy link
Copy Markdown
Contributor Author

ms32035 commented Jan 9, 2018

can this be merged? I plan to expand the sendgrid backend basing on this

@fenglu-db
Copy link
Copy Markdown
Contributor

@criccomini could you help on merging this PR?

@criccomini
Copy link
Copy Markdown
Contributor

lgtm!

@asfgit asfgit closed this in 97680d8 Jan 10, 2018
Acehaidrey pushed a commit to Acehaidrey/incubator-airflow that referenced this pull request Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants