Fix TestSsmHooks which is not compatible with moto==4.1.1#29118
Merged
Taragolis merged 1 commit intoapache:mainfrom Jan 24, 2023
Merged
Fix TestSsmHooks which is not compatible with moto==4.1.1#29118Taragolis merged 1 commit intoapache:mainfrom
moto==4.1.1#29118Taragolis merged 1 commit intoapache:mainfrom
Conversation
boring-cyborg
bot
added
area:providers
provider:amazon
Taragolis
added
the
type:misc/internal
josh-fell
approved these changes
Jan 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent version of
moto==4.1.1broke our main, this PR introduce fixe.The problem that we do not pass all mandatory fields to SsmClient.put_parameter method and
motobefore 4.1.1 ignored this check: getmoto/moto#5835