Skip to content

Comments

Fix commit title for constraint commits#29236

Merged
jedcunningham merged 1 commit intoapache:mainfrom
potiuk:fixup-to-constraint-commit
Jan 30, 2023
Merged

Fix commit title for constraint commits#29236
jedcunningham merged 1 commit intoapache:mainfrom
potiuk:fixup-to-constraint-commit

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jan 30, 2023

The ##29215 nicely fixed the content of commit message but there is one more fix needed to fix the commit message.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The #apache#29215 nicely fixed the content of commit message but there
is one more fix needed to fix the commit message.
@potiuk potiuk requested a review from ashb as a code owner January 30, 2023 10:53
@potiuk potiuk requested a review from ephraimbuddy January 30, 2023 10:54
@potiuk
Copy link
Member Author

potiuk commented Jan 30, 2023

It already looks way better (but the commit title is still somewhat meaningless):

image

@potiuk potiuk requested a review from eladkal January 30, 2023 20:29
@jedcunningham jedcunningham merged commit 0369e96 into apache:main Jan 30, 2023
@potiuk potiuk added this to the Airflow 2.5.2 milestone Feb 8, 2023
@pierrejeambrun pierrejeambrun added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 6, 2023
pierrejeambrun pushed a commit that referenced this pull request Mar 7, 2023
The ##29215 nicely fixed the content of commit message but there
is one more fix needed to fix the commit message.

(cherry picked from commit 0369e96)
pierrejeambrun pushed a commit that referenced this pull request Mar 8, 2023
The ##29215 nicely fixed the content of commit message but there
is one more fix needed to fix the commit message.

(cherry picked from commit 0369e96)
@potiuk potiuk deleted the fixup-to-constraint-commit branch March 22, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants