Skip to content

[AIRFLOW-511] add success/failure callbacks on dag level#2934

Closed
Acehaidrey wants to merge 1 commit intoapache:masterfrom
Acehaidrey:AIRFLOW-511
Closed

[AIRFLOW-511] add success/failure callbacks on dag level#2934
Acehaidrey wants to merge 1 commit intoapache:masterfrom
Acehaidrey:AIRFLOW-511

Conversation

@Acehaidrey
Copy link
Contributor

@Acehaidrey Acehaidrey commented Jan 12, 2018

Make sure you have checked all steps below.

JIRA

Description

  • Here are some details about my PR, including screenshots of any UI changes:
    Currently when a dagrun timeout happens there is not an alert sent off on a task failure callback because the way it works is that a timeout just prevents downstream tasks from getting scheduled and it allows the task currently running to finish out. There is not much insight that the dag actually stopped which should definitely be caught.
    Also there are certain callbacks you may want once the entire dag has completed successfully as well, making sense to have both callbacks.

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Tests the callbacks for on success, on failure, and also checks that a dagrun timeout also triggers the callback.

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"
  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

@codecov-io
Copy link

codecov-io commented Jan 12, 2018

Codecov Report

Merging #2934 into master will increase coverage by 0.02%.
The diff coverage is 85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2934      +/-   ##
==========================================
+ Coverage   73.46%   73.49%   +0.02%     
==========================================
  Files         160      160              
  Lines       12208    12228      +20     
==========================================
+ Hits         8969     8987      +18     
- Misses       3239     3241       +2
Impacted Files Coverage Δ
airflow/jobs.py 79.49% <100%> (+0.01%) ⬆️
airflow/models.py 86.97% <84.21%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc72231...42cb98d. Read the comment docs.

@Acehaidrey Acehaidrey force-pushed the AIRFLOW-511 branch 10 times, most recently from 6895bf3 to 6db3a19 Compare January 18, 2018 01:57
@Acehaidrey
Copy link
Contributor Author

@Swalloow thanks for pointing out the typo

@asfgit asfgit closed this in c3c4a8f Jan 19, 2018
@Acehaidrey Acehaidrey deleted the AIRFLOW-511 branch January 19, 2018 18:42
Acehaidrey added a commit to Acehaidrey/incubator-airflow that referenced this pull request Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants