[AIRFLOW-511] add success/failure callbacks on dag level#2934
Closed
Acehaidrey wants to merge 1 commit intoapache:masterfrom
Closed
[AIRFLOW-511] add success/failure callbacks on dag level#2934Acehaidrey wants to merge 1 commit intoapache:masterfrom
Acehaidrey wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2934 +/- ##
==========================================
+ Coverage 73.46% 73.49% +0.02%
==========================================
Files 160 160
Lines 12208 12228 +20
==========================================
+ Hits 8969 8987 +18
- Misses 3239 3241 +2
Continue to review full report at Codecov.
|
6895bf3 to
6db3a19
Compare
6db3a19 to
42cb98d
Compare
Contributor
Author
|
@Swalloow thanks for pointing out the typo |
Acehaidrey
added a commit
to Acehaidrey/incubator-airflow
that referenced
this pull request
Jan 19, 2018
Closes apache#2934 from Acehaidrey/AIRFLOW-511
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
JIRA
Description
Currently when a dagrun timeout happens there is not an alert sent off on a task failure callback because the way it works is that a timeout just prevents downstream tasks from getting scheduled and it allows the task currently running to finish out. There is not much insight that the dag actually stopped which should definitely be caught.
Also there are certain callbacks you may want once the entire dag has completed successfully as well, making sense to have both callbacks.
Tests
Tests the callbacks for on success, on failure, and also checks that a dagrun timeout also triggers the callback.
Commits
My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
Passes
git diff upstream/master -u -- "*.py" | flake8 --diff