migrating from unittest to pytest tests cli file#29354
migrating from unittest to pytest tests cli file#29354Taragolis merged 3 commits intoapache:mainfrom Abhishek-kumar-ISM:migrating_from_unittest_to_pytest_tests_cli
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
|
There is also one file exists in cli which use airflow/tests/cli/commands/test_task_command.py Lines 337 to 346 in ce67786 It would be nice to replace it by This example could be helpful: airflow/tests/models/test_variable.py Lines 69 to 72 in b4a7379 |
|
@Taragolis Yes i will do |
|
@Taragolis completed the changes you said. file running fine in which i did changes. |
|
Let's wait till CI green. General recommendation it is setup pre-commit, this step will save ton of your time, see STATIC CHECKS |
|
Okay, i will remove all unused imports. |
|
@Taragolis |
|
Awesome work, congrats on your first merged pull request! |
I have migrated one test file from unittest to pytest. All test cases of this file are running normally as earlier.
related: #29305