Merged
Conversation
potiuk
force-pushed
the
check-typing-fix-in-tenacity
branch
4 times, most recently
from
f59fdc7 to
802ab19
Compare
eladkal
approved these changes
Feb 9, 2023
uranusjr
reviewed
Feb 10, 2023
potiuk
force-pushed
the
check-typing-fix-in-tenacity
branch
from
049eea2 to
e33d575
Compare
Tenacity MyPy integration has been broken in 8.2.0, but 8.2.1 seems to fix it. Test fix provided in jd/tenacity#390 Related: apache#29411
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
potiuk
force-pushed
the
check-typing-fix-in-tenacity
branch
from
e33d575 to
41d80c1
Compare
uranusjr
approved these changes
Feb 12, 2023
pierrejeambrun
added
the
type:misc/internal
pierrejeambrun
added
changelog:skip
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 7, 2023
* Bring back fixed tenacity. Tenacity MyPy integration has been broken in 8.2.0, but 8.2.1 seems to fix it. Test fix provided in jd/tenacity#390 Related: #29411 Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 28806a3)
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 8, 2023
* Bring back fixed tenacity. Tenacity MyPy integration has been broken in 8.2.0, but 8.2.1 seems to fix it. Test fix provided in jd/tenacity#390 Related: #29411 Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 28806a3)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test fix provided in jd/tenacity#390
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.