Add note about workaround to potential error with argparse to hdfs#29614
Merged
potiuk merged 1 commit intoapache:mainfrom Feb 19, 2023
Merged
Conversation
Instead of removing or reimplementing hdfs provider - in the event of a possibility to break argparse, we simply add a note in the provider documentation to remove argprase if such problem happens. Fixes: apache#22689
Taragolis
approved these changes
Feb 19, 2023
Contributor
Taragolis
left a comment
Taragolis
left a comment
There was a problem hiding this comment.
I think also would be nice to detect if it installed and "spam" into the log, e.g. in Hook constructor or in get_conn(). But it can be done by follow-up
Member
Author
|
It's a niche case but yes. We could detect it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of removing or reimplementing hdfs provider - in the event of a possibility to break argparse, we simply add a note in the provider documentation to remove argprase if such problem happens.
Fixes: #22689
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.