this file adds a on_kill method to Dataproc operator.#29683
Closed
nervoussidd wants to merge 1 commit intoapache:mainfrom
Closed
this file adds a on_kill method to Dataproc operator.#29683nervoussidd wants to merge 1 commit intoapache:mainfrom
nervoussidd wants to merge 1 commit intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
Member
|
This is not valid Python. Did you test it? |
Author
|
Hello Tzu,
No I didn't tested. I was looking for the guidance but I didn't knew whom
to approach so I just learn some basic stuff like about the libraries and
about the methods and wrote this code.
Can u please guide me so that I can work on this and get this merged.
And thank you for the feedback.
Thank you
Thank You
…On Wed, Feb 22, 2023, 11:02 AM Tzu-ping Chung ***@***.***> wrote:
This is not valid Python. Did you test it?
—
Reply to this email directly, view it on GitHub
<#29683 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUA2XLWPKKSGCE6ZVWMK6CLWYWQHVANCNFSM6AAAAAAVD3TETQ>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Member
|
Start with reading one of the CONTRIBUTING guides listed here: https://github.com/apache/airflow/ |
Author
|
Thanks, I'll check it out.
…On Wed, Feb 22, 2023, 11:35 AM Tzu-ping Chung ***@***.***> wrote:
Start with reading one of the CONTRIBUTING guides listed here:
https://github.com/apache/airflow/
—
Reply to this email directly, view it on GitHub
<#29683 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUA2XLQVF22QCBXLKPIGVQLWYWUCZANCNFSM6AAAAAAVD3TETQ>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.