Skip to content

this file adds a on_kill method to Dataproc operator.#29683

Closed
nervoussidd wants to merge 1 commit intoapache:mainfrom
nervoussidd:cancel-dataproc-workflow-onkill
Closed

this file adds a on_kill method to Dataproc operator.#29683
nervoussidd wants to merge 1 commit intoapache:mainfrom
nervoussidd:cancel-dataproc-workflow-onkill

Conversation

@nervoussidd
Copy link


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Feb 22, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@nervoussidd nervoussidd reopened this Feb 22, 2023
@uranusjr
Copy link
Member

This is not valid Python. Did you test it?

@nervoussidd
Copy link
Author

nervoussidd commented Feb 22, 2023 via email

@uranusjr
Copy link
Member

uranusjr commented Feb 22, 2023

Start with reading one of the CONTRIBUTING guides listed here: https://github.com/apache/airflow/

@nervoussidd
Copy link
Author

nervoussidd commented Feb 22, 2023 via email

@github-actions
Copy link

github-actions bot commented Apr 9, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Apr 9, 2023
@github-actions github-actions bot closed this Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments