Move sqlalchemy.ext.declarative imports to orm#29862
Merged
Merged
Conversation
uranusjr
requested review from
XD-DENG,
ashb,
bbovenzi,
ephraimbuddy,
kaxil and
ryanahamilton
as code owners
boring-cyborg
Bot
added
area:API
josh-fell
approved these changes
Mar 2, 2023
These imports are being moved to sqlalchemy.orm, and are also available there in 1.4 (which we use), so let's move them to ease the eventual migration to 2.0.
uranusjr
force-pushed
the
move-sqlalchemy-import
branch
from
613992f to
7c76179
Compare
pierrejeambrun
added
the
changelog:skip
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 23, 2023
(cherry picked from commit c4f8e22)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These imports are being moved to sqlalchemy.orm, and are also available there in 1.4 (which we use), so let's move them to ease the eventual migration to 2.0.
See https://docs.sqlalchemy.org/en/20/changelog/migration_20.html