Skip to content

Correct link to best_practice(s) section#29876

Merged
potiuk merged 1 commit into
apache:mainfrom
mayeulk:patch-1
Mar 2, 2023
Merged

Correct link to best_practice(s) section#29876
potiuk merged 1 commit into
apache:mainfrom
mayeulk:patch-1

Conversation

@mayeulk
Copy link
Copy Markdown
Contributor

@mayeulk mayeulk commented Mar 2, 2023

Logical link <best_practices/airflow_variables> fails. In similar file faq.rst, logical link DAG writing best practices<best_practice:writing_a_dag> (without "s" at practice) works.

I could not deploy and test; however based on similarity, the above should fix the broken link in:
https://airflow.apache.org/docs/apache-airflow/2.5.1/howto/dynamic-dag-generation.html#dynamic-dags-with-environment-variables

Logical link <best_practices/airflow_variables> fails.
In similar file faq.rst, logical link `DAG writing best practices<best_practice:writing_a_dag>` (without "s" at practice) works.
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented Mar 2, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk merged commit 43d48e1 into apache:main Mar 2, 2023
@boring-cyborg
Copy link
Copy Markdown

boring-cyborg Bot commented Mar 2, 2023

Awesome work, congrats on your first merged pull request!

@potiuk
Copy link
Copy Markdown
Member

potiuk commented Mar 2, 2023

thanks!

@potiuk potiuk added this to the Airflow 2.5.2 milestone Mar 2, 2023
@pierrejeambrun pierrejeambrun added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 6, 2023
pierrejeambrun pushed a commit that referenced this pull request Mar 7, 2023
Logical link <best_practices/airflow_variables> fails.
In similar file faq.rst, logical link `DAG writing best practices<best_practice:writing_a_dag>` (without "s" at practice) works.

(cherry picked from commit 43d48e1)
pierrejeambrun pushed a commit that referenced this pull request Mar 8, 2023
Logical link <best_practices/airflow_variables> fails.
In similar file faq.rst, logical link `DAG writing best practices<best_practice:writing_a_dag>` (without "s" at practice) works.

(cherry picked from commit 43d48e1)
@mayeulk mayeulk deleted the patch-1 branch March 11, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) kind:documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants