Revert "Decouple production executor warning in dags UI (#29609)"

[potiuk]

This reverts commit 88ed20a.

---

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

[potiuk]

Not sure why, but I think ##29609 broken pytest collection in main (looks like a circular import). For some reason it did not happen in the original PR.

We should merge it (and find the cause) as both PRs started to fail with:

    from airflow.executors import celery_executor, celery_kubernetes_executor
airflow/executors/celery_executor.py:40: in <module>
    from celery import Celery, Task, states as celery_states
E   ImportError: cannot import name 'Celery' from 'celery' (/usr/local/lib/python3.7/site-packages/celery/__init__.py)

For example here: https://github.com/apache/airflow/actions/runs/4333507290/jobs/7566768495

[potiuk]

@o-nikolas - you will have to redo that one again and we need to carefully look at what was going on with the import.

[o-nikolas]

@o-nikolas - you will have to redo that one again and we need to carefully look at what was going on with the import.

Interesting, I'll have to find the way to replicate the error on my end. Both my local testing and the PR didn't show the issue. I'll look on Monday. And thanks for the revert 👍

[potiuk]

Yep. Strange. I need approval to merge it though :)

[potiuk]

I also added this one #29923 to clearer show when things like that happen (there will be separate job doing the test collection) and also allowing the other jobs in CI to continue even if collection fail.

[potiuk]

🙏 :) @o-nikolas

[potiuk]

Strange enough it did NOT fail in #29923 ... so I start thinking there could be some intermediate problem.

[potiuk]

I think it is a different thing - side-effect of argcomplete released few moments ago (which drags importlb upgrade with it).

[potiuk]

Confirmed. This is a regrression in importlib_metadata that will be fixed in upcoming celerly 5.3. Workaround is coming.

[potiuk]

(so no need to take a look @o-nikolas )

[potiuk]

the right fix is here #29924

[o-nikolas]

Nice, glad this worked out 😃 I was unavailable this weekend and only had a few mins to check this PR on my phone!