Add missing poll_interval in Bigquery operator#30132
Merged
potiuk merged 4 commits intoapache:mainfrom Mar 16, 2023
Merged
Conversation
boring-cyborg
bot
added
area:providers
provider:google
pankajastro
force-pushed
the
add_missing_poll_interval
branch
from
76af35e to
a0cf1a4
Compare
pankajastro
force-pushed
the
add_missing_poll_interval
branch
from
2706f2e to
8a67f8d
Compare
josh-fell
approved these changes
Mar 15, 2023
hussein-awala
approved these changes
Mar 16, 2023
Member
hussein-awala
left a comment
hussein-awala
left a comment
There was a problem hiding this comment.
Maybe we need to mention that it is used only in deferrable mode, WDYT?
potiuk
approved these changes
Mar 16, 2023
Member
Good idea. |
64 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
recently, I fixed the missing
poll_intervalfor BigQueryInsertJobOperator #30091 but looks like this is missing for all the Bigquery-related aync operators and currently, poll_interval is a fixed value. This PR exposes poll_interval param in bigquery operators which support deferrable mode^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.