Skip to content

Comments

fix NameError "MappedTaskGroup" Not Found#30194

Closed
xjf729 wants to merge 1 commit intoapache:mainfrom
xjf729:fix-NameError
Closed

fix NameError "MappedTaskGroup" Not Found#30194
xjf729 wants to merge 1 commit intoapache:mainfrom
xjf729:fix-NameError

Conversation

@xjf729
Copy link
Contributor

@xjf729 xjf729 commented Mar 20, 2023

In thise line,it explicitly used MappedTaskGroup. But MappedTaskGroup is just imported when TYPE_CHECKING. Therefore, there is a NameError during runtime.

@xjf729 xjf729 requested review from XD-DENG, ashb and kaxil as code owners March 20, 2023 01:53
@uranusjr
Copy link
Member

Should be OK to import it here.

@uranusjr
Copy link
Member

Need to fix failing static check.

@potiuk
Copy link
Member

potiuk commented Mar 21, 2023

And it needs rebase now after some conflicts.

@github-actions
Copy link

github-actions bot commented May 6, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label May 6, 2023
@github-actions github-actions bot closed this May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants