You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Does this not apply to basically all attributes on task? The fix would be no more than a band-aid (and too easy to be undone) if that is the case.
@uranusjr I don't look at it as a band-aid, my understanding is that a queue is assigned not to a task but to the instance of a task that relates to a particular DagRun. task_instance_mutation_hook is not called again when clearing a task instance, so any changes you make to a queue in the hook will no longer apply after clearing that task instance. Maybe a better approach would be to call task_instance_mutation_hook on clear to be able to apply same logic when task instance is first being created?
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will update logic to preserve original assigned queue when clearing a task. This PR was created based on the discussion in #20143.