-
Notifications
You must be signed in to change notification settings - Fork 16.2k
[AIRFLOW-2100] Fix Broken Documentation Links #3033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fokko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With a few changes I think it is good to merge this now, and then get another place where the docs of Airflow 1.9 are hosted.
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make it https://.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make it https:// and I think it would be wise to explicitly mention that these docs are the latest and not the latest release.
- Replaced `Pythonhosted` documentation links with `Apache Docs`
|
@kaxil Thanks for fixing! |
Codecov Report
@@ Coverage Diff @@
## master #3033 +/- ##
=======================================
Coverage 73.21% 73.21%
=======================================
Files 178 178
Lines 12475 12475
=======================================
Hits 9134 9134
Misses 3341 3341Continue to review full report at Codecov.
|
- Replaced `Pythonhosted` documentation links with `Apache Docs` Closes apache#3033 from kaxil/AIRFLOW-2100
Make sure you have checked all steps below.
JIRA
Description
Pythonhosteddocumentation links withApache Docsas agreed and documented here: https://cwiki.apache.org/confluence/display/AIRFLOW/Building+and+deploying+the+docs?show-miniviewTests
Docs changed
Commits
My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
Passes
git diff upstream/master -u -- "*.py" | flake8 --diff