Skip to content

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Feb 11, 2018

Make sure you have checked all steps below.

JIRA

Description

Tests

  • My PR adds the following unit tests OR does not need testing for this extremely good reason:
    Docs changed

Commits

  • My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":

    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"
  • Passes git diff upstream/master -u -- "*.py" | flake8 --diff

Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a few changes I think it is good to merge this now, and then get another place where the docs of Airflow 1.9 are hosted.

README.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it https://.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

README.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it https:// and I think it would be wise to explicitly mention that these docs are the latest and not the latest release.

- Replaced `Pythonhosted` documentation links with `Apache Docs`
@kaxil
Copy link
Member Author

kaxil commented Feb 12, 2018

@Fokko

  • Readthedocs links point to the latest GitHub version of Airflow. link
  • Apache Doc links point to latest stable release i.e. 1.9 for now. link

@asfgit asfgit closed this in 6e634dd Feb 12, 2018
@Fokko
Copy link
Contributor

Fokko commented Feb 12, 2018

@kaxil Thanks for fixing!

@kaxil kaxil deleted the AIRFLOW-2100 branch February 12, 2018 16:34
@codecov-io
Copy link

Codecov Report

Merging #3033 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3033   +/-   ##
=======================================
  Coverage   73.21%   73.21%           
=======================================
  Files         178      178           
  Lines       12475    12475           
=======================================
  Hits         9134     9134           
  Misses       3341     3341

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a289497...4bdf3ba. Read the comment docs.

aliceabe pushed a commit to aliceabe/incubator-airflow that referenced this pull request Jan 3, 2019
- Replaced `Pythonhosted` documentation links with
`Apache Docs`

Closes apache#3033 from kaxil/AIRFLOW-2100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants