Ensure teardown failure with on_failure_fail_dagrun=True fails the DagRun#30398
Merged
ephraimbuddy merged 6 commits intoapache:mainfrom May 8, 2023
Merged
Ensure teardown failure with on_failure_fail_dagrun=True fails the DagRun#30398ephraimbuddy merged 6 commits intoapache:mainfrom
ephraimbuddy merged 6 commits intoapache:mainfrom
Conversation
ephraimbuddy
added
the
changelog:skip
ephraimbuddy
force-pushed
the
determine-dag-success
branch
from
555c63a to
f6b0740
Compare
ephraimbuddy
force-pushed
the
determine-dag-success
branch
3 times, most recently
from
d7cd3f3 to
c82b9ce
Compare
ephraimbuddy
force-pushed
the
determine-dag-success
branch
2 times, most recently
from
190c121 to
6425f2e
Compare
jedcunningham
approved these changes
May 5, 2023
…gRun My approach here is not to include teardown tasks in the leaf_tis when deciding on dagrun state except if the teardown task has _on_failure_fail_dagrun set
ephraimbuddy
force-pushed
the
determine-dag-success
branch
from
6425f2e to
90d0b23
Compare
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My approach here is not to include teardown tasks in the leaf_tis when deciding on dagrun state except if the teardown task has _on_failure_fail_dagrun set
closes: #29125