Closed
Conversation
agalst
requested review from
XD-DENG,
ashb,
bbovenzi,
bolkedebruin,
dstandish,
eladkal,
ephraimbuddy,
jedcunningham,
kaxil,
o-nikolas,
ryanahamilton and
uranusjr
as code owners
boring-cyborg
bot
added
area:API
o-nikolas
reviewed
Mar 31, 2023
|
|
||
| from http import HTTPStatus | ||
|
|
||
| import pendulum |
Contributor
There was a problem hiding this comment.
The pendulum module must be loaded in either case here. I don't think you will see a performance gain from a change like this.
I ran a very quick couple of commands to test this:
You can see that they're the same (even the from case being slower, but this is normal variance of course).
Author
There was a problem hiding this comment.
Indeed, speed-wise seems there is no real difference. However, importing the whole pandas namespace to use only DataFrame seems excessive. What do you think @o-nikolas ?
Member
There was a problem hiding this comment.
That’s not how Python works. import pandas and from pandas import DataFrame has exactly the same import time.
Member
|
Sorry for being blunt, but this is useless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unnecessary general imports for performance improvement
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.